-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve tree-shaking in ESM target #1124
Merged
samchon
merged 4 commits into
samchon:master
from
ryoppippi:feature/improve-tree-shaking-build
Jun 27, 2024
Merged
refactor: improve tree-shaking in ESM target #1124
samchon
merged 4 commits into
samchon:master
from
ryoppippi:feature/improve-tree-shaking-build
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terser plugin has been removed from the project as it's no longer needed. The TypeScript target and module have been updated to "ESNext" to align with the latest ECMAScript features.
This commit replaces the @__PURE__ annotation with #__PURE__ across multiple files. This change is purely stylistic and does not affect the functionality of the code.
de7678b
to
554d424
Compare
This commit adds the "sideEffects" property to package.json and sets it to false. This is useful for tree shaking during the build process, as it informs webpack that the package doesn't introduce any side effects when imported.
The rollup configuration has been updated to preserve modules and their root. This change is reflected in the output configuration where the 'preserveModules' and 'preserveModulesRoot' options have been set.
Thanks for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /#PURE/ comment was missing from the build in the previous roolup configuration.
After modifying the configuration, /#PURE/ comments now remain after the build, and vite, bun and esbuild can use this information for tree-shaking.
Also, the PURE comment has been changed, as the current mainstream one is "/#PURE/" instead of "/* @PURE */".
Learn more about the CONTRIBUTING