Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve tree-shaking in ESM target #1124

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

ryoppippi
Copy link
Contributor

The /#PURE/ comment was missing from the build in the previous roolup configuration.
After modifying the configuration, /#PURE/ comments now remain after the build, and vite, bun and esbuild can use this information for tree-shaking.

Also, the PURE comment has been changed, as the current mainstream one is "/#PURE/" instead of "/* @PURE */".

# COMPILE
npm run build

# RE-WRITE TEST PROGRAMS IF REQUIRED
npm run test:template

# BUILD TEST PROGRAM
npm run build:test

# DO TEST
npm run test

Learn more about the CONTRIBUTING

@ryoppippi ryoppippi changed the title refactor: remove terser and update TypeScript target refactor: improve tree-shaking in ESM target Jun 26, 2024
@ryoppippi ryoppippi marked this pull request as draft June 26, 2024 16:19
The terser plugin has been removed from the project as it's no longer
needed. The TypeScript target and module have been updated to "ESNext"
to align with the latest ECMAScript features.
This commit replaces the @__PURE__ annotation with #__PURE__ across
multiple files. This change is purely stylistic and does not affect
the functionality of the code.
@ryoppippi ryoppippi force-pushed the feature/improve-tree-shaking-build branch from de7678b to 554d424 Compare June 26, 2024 16:21
This commit adds the "sideEffects" property to package.json and sets it
to false. This is useful for tree shaking during the build process, as
it informs webpack that the package doesn't introduce any side effects
when imported.
The rollup configuration has been updated to preserve modules and their
root. This change is reflected in the output configuration where the
'preserveModules' and 'preserveModulesRoot' options have been set.
@ryoppippi ryoppippi marked this pull request as ready for review June 26, 2024 16:58
@ryoppippi ryoppippi marked this pull request as draft June 26, 2024 17:03
@ryoppippi ryoppippi marked this pull request as ready for review June 26, 2024 17:22
@samchon samchon merged commit be23d7d into samchon:master Jun 27, 2024
5 checks passed
@samchon
Copy link
Owner

samchon commented Jun 27, 2024

Thanks for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants