Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MetataProperty to support dynamic properties #200

Closed
samchon opened this issue Sep 20, 2022 · 0 comments
Closed

Refactor MetataProperty to support dynamic properties #200

samchon opened this issue Sep 20, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@samchon
Copy link
Owner

samchon commented Sep 20, 2022

To support dynamic properties (#153), type of MetadataProperty.name must be changed from string to Metadata.

However, MetadataProperty already has been possessed the Metadata type in the MetadataProperty.metadata property. For clean design, it would better to rename MetadataProperty.name to key and MetadataProperty.metadata as value. Therefore, after implementing following this issue, MetadataProperty would be like below:

export class MetadataProperty {
    public readonly key: Metadata;
    public readonly value: Metadata;
    public readonly description: string | undefined;
    public readonly tags: IMetadataTag[];
    public readonly jsDocTags: IJsDocTagInfo[];
}

Also, many Programmer classes would be refactored by this change.

@samchon samchon added the enhancement New feature or request label Sep 20, 2022
@samchon samchon self-assigned this Sep 20, 2022
samchon added a commit that referenced this issue Sep 20, 2022
Close #200, refactor `MetadataProperty` for dynamic properties
@samchon samchon closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant