Close #380 - prohibit non-strict option #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too many `nestia` users are confusing by legacy projects that had configured `strictNullChecks: false`, and mis-report to my repo saying "nestia seems broken". I think it would better to entirely prohibit `strictNullChecks: false` option in compliation level. Therefore, since v4.0.4 update, `strictNullChecks: false` would be compilation error in every nestia utilizing projects. Also, made SDK generator to prohibit implicit return in controller method without any type definition. It's because if SDK allows object literal expression without type definition, client developers utilizing the SDK library would be crazy due to they have to read backend server code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many
nestiausers are confusing by legacy projects that had configuredstrictNullChecks: false, and mis-report to my repo saying "nestia seems broken".I think it would better to entirely prohibit
strictNullChecks: falseoption in compliation level. Therefore, since v4.0.4 update,strictNullChecks: falsewould be compilation error in every nestia utilizing projects.Also, made SDK generator to prohibit implicit return in controller method without any type definition. It's because if SDK allows object literal expression without type definition, client developers utilizing the SDK library would be crazy due to they have to read backend server code.