Add peerDependencies in core and sdk
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchon
commented
Apr 13, 2023
There was a problem hiding this comment.
Unfortunately, older version of @nestjs/common had not exported ModuleMetadata.
Using Parameters TMP type is for such case.
There was a problem hiding this comment.
Older version of rxjs had not exported Observable, and had to import through rxjs/operators file.
There was a problem hiding this comment.
ts-node had worked well until 10.6.0 patch.
There was a problem hiding this comment.
This is result of analyses of dependency relationships of NestJS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeded to complicate dependency relationship of NestJS.
Therefore, restrict dependencies of NestJS through
peerDependencies