fix : Too long return type fails to generate SDK #282 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ts.TypeFormatFlags.NoTruncation apply - I don't know how to test it work correctly, so I need your help.
|
@kakasoo Upgrade to |
samchon
added a commit
that referenced
this pull request
Mar 27, 2023
Thx. This was absolutely necessary for me. Good night! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have previously said in issue #282 that "the problem is that too long types are not properly deduced". This was very important to me, so I analyzed the TypeScript compiler and solved the problem. This problem was too simple. The problem was solved by simply passing the flag to the TypeScript compiler. In my code this worked perfectly. Unfortunately, however, I don't know if this works only with my code or how I can test the nestia library.
So I have no choice but to ask for your help for the next time. I would appreciate it if you could check the PR and reflect it if there is no problem.
Thank you always for making such a wonderful library.