Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BadRequestExeption returned as 500 error by Nest #327

Closed
mmamedel opened this issue May 2, 2023 · 2 comments
Closed

BadRequestExeption returned as 500 error by Nest #327

mmamedel opened this issue May 2, 2023 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@mmamedel
Copy link

mmamedel commented May 2, 2023

Bug Report

500 error from Nest v9.0.0 when using TypedParam.
A similar problem for another library was reported here:
nestjs/nest#5241
Suggestion was:

Shared libraries should list @nestjs/core and @nestjs/common as peerDependencies. Otherwise, httpException instanceof HttpException in which httpException is thrown from shared library will give false value.

Which makes sense, as I noticed that Nestia has these nest libraries listed as dependencies, not as peerDependencies. Do you think the adjustment could be made?

@samchon
Copy link
Owner

samchon commented May 3, 2023

You mean that @nestia/core has to assign same properties from dependencies to peerDependencies, right?

If possible, can you make a demo repo that reproducing the bug?

Also, about the peerDependencies definition, I'll wait your PR.

@samchon samchon self-assigned this May 3, 2023
@samchon samchon added the help wanted Extra attention is needed label May 3, 2023
@samchon samchon closed this as completed in adbc5d4 May 5, 2023
samchon added a commit that referenced this issue May 5, 2023
Fix #327 and #335: break change from `nest.createParamDecorator` + `fastify` support
@samchon
Copy link
Owner

samchon commented May 5, 2023

Upgrade, then be fixed

npm i -D nestia@latest
npx nestia setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants