Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featuer Request: How about throw BadRequest when invalid type error in @TypedQuery. #320

Closed
rojiwon123 opened this issue Apr 27, 2023 · 1 comment
Closed

Featuer Request: How about throw BadRequest when invalid type error in @TypedQuery. #320

rojiwon123 opened this issue Apr 27, 2023 · 1 comment
Assignees
@samchon
Labels
enhancement New feature or request

Comments

@rojiwon123
Copy link
Contributor

@TypedQuery 데코레이터는 유효하지 않은 타입이 확인되면, 일반적인 에러를 throw합니다. 저는 @TypedQuery가 @TypedBody, @TypedParam처럼 BadRequestException을 throw하는 것이 일관성있어 보인다고 생각합니다. 어떤가요?

The @TypedQuery decorator currently throws a general error when an invalid type is detected. I believe that it would be more consistent if @TypedQuery threw a BadRequestException like @TypedBody and @TypedParam do. What do you think?"
@samchon samchon self-assigned this Apr 27, 2023
@samchon samchon added the enhancement New feature or request label Apr 27, 2023
@samchon
Copy link
Owner

samchon commented Apr 27, 2023

Good idea, but do not use Korean please.

Anyway, upgrade to @nestia/core@1.1.1, then become as you wish.

samchon added a commit that referenced this issue Apr 27, 2023
@samchon
Merge pull request #321 from samchon/features/query
69e61d4 
Close #320: `TypedQuery` also throws 400 status error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samchon samchon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samchon @rojiwon123