Optimize allocation in AppendRecordAttrsToAttrs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
commented
Dec 17, 2024
| @@ -17,7 +17,8 @@ import ( | |||
| type ReplaceAttrFn = func(groups []string, a slog.Attr) slog.Attr | |||
|
|
|||
| func AppendRecordAttrsToAttrs(attrs []slog.Attr, groups []string, record *slog.Record) []slog.Attr { | |||
| output := slices.Clone(attrs) | |||
| output := make([]slog.Attr, 0, len(attrs)+record.NumAttrs()) | |||
| output = append(output, attrs...) | |||
There was a problem hiding this comment.
I guess one could create a new helper in your lo library of functions like CloneAllocate or something :-)
Now that I think about it copy is probably better here.
|
I appreciate your suggestion. I have identified other optimizations to make in the project. Log processing can be costly if coded badly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA, not sure if you will like it this repo smells with functional programming and I am not sure if this fits the bill :-)
Whatever, cheers!