Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in README.md MapValues should be MapToSlice #190

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

CorentinClabaut
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #190 (99b9ffd) into master (579b1d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files          13       13           
  Lines        1534     1534           
=======================================
  Hits         1390     1390           
  Misses        141      141           
  Partials        3        3           
Flag Coverage Δ
unittests 90.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579b1d5...99b9ffd. Read the comment docs.

@CorentinClabaut
Copy link
Contributor Author

@samber MapToSlice iteratee is func(V, K) where func(K, V) seems more intuitive.

Would it be worth fixing that eventhough that would break existing code that uses it?

@samber
Copy link
Owner

samber commented Jul 29, 2022

Oh yes!

I didn't spot this error last Sunday.

This helper was added very recently. I think we can fix it today without breaking too much code.

@samber samber merged commit 85e3ab2 into samber:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants