perf: optimize code (yearn#379)

sambacha · Sep 7, 2021 · 69b90e6 · 69b90e6
1 parent 7f8c9fc
commit 69b90e6
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/contracts/Vault.vy b/contracts/Vault.vy
@@ -963,19 +963,18 @@ def _reportLoss(strategy: address, loss: uint256):
     assert totalDebt >= loss
 
     # Also, make sure we reduce our trust with the strategy by the amount of loss
-    ratio_change: uint256 = 0
     if self.debtRatio != 0: # if vault with single strategy that is set to EmergencyOne
-        ratio_change = min(
+        ratio_change: uint256 = min(
             # NOTE: This calculation isn't 100% precise, the adjustment is ~10%-20% more severe due to EVM math
             loss * self.debtRatio / self.totalDebt,
             self.strategies[strategy].debtRatio,
         )
+        self.strategies[strategy].debtRatio -= ratio_change
+        self.debtRatio -= ratio_change
     # Finally, adjust our strategy's parameters by the loss
     self.strategies[strategy].totalLoss += loss
     self.strategies[strategy].totalDebt = totalDebt - loss
     self.totalDebt -= loss
-    self.strategies[strategy].debtRatio -= ratio_change
-    self.debtRatio -= ratio_change
 
 
 @external