readline: revert semver-major of 28109

PR-URL: nodejs#28109
sam-github · Jun 10, 2019 · f832e86 · f832e86
1 parent 006cda5
commit f832e86
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -121,7 +121,7 @@ function Interface(input, output, completer, terminal) {
     input = input.input;
   }
 
-  if (completer !== undefined && typeof completer !== 'function') {
+  if (completer && typeof completer !== 'function') {
     throw new ERR_INVALID_OPT_VALUE('completer', completer);
   }
 

diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js
@@ -367,25 +367,19 @@ function isWarned(emitter) {
       code: 'ERR_INVALID_OPT_VALUE'
     });
 
-    common.expectsError(function() {
+    common.mustCall(function() {
       readline.createInterface({
         input: fi,
         completer: ''
       });
-    }, {
-      type: TypeError,
-      code: 'ERR_INVALID_OPT_VALUE'
-    });
+    })();
 
-    common.expectsError(function() {
+    common.mustCall(function() {
       readline.createInterface({
         input: fi,
         completer: false
       });
-    }, {
-      type: TypeError,
-      code: 'ERR_INVALID_OPT_VALUE'
-    });
+    })();
   }
 
   // Constructor throws if historySize is not a positive number