Added Universal binary option for macOS #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andirsun
reviewed
Aug 5, 2022
There was a problem hiding this comment.
I dont see the --universal option on electron builder CLI options, can you point me out to the code?
https://www.electron.build/cli
Nevermind I found it. electron-userland/electron-builder#5689 (comment) |
|
@m5x5 please review this. |
saltyshiomix
added
enhancement
saltyshiomix
approved these changes
Aug 27, 2022
saltyshiomix
added a commit
that referenced
this pull request
Aug 27, 2022
|
@arunavo4 CC: @andirsun @milanmdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@saltyshiomix The
--universalflag was missing for the macOS . I added the flag for people who wants to create the macOS Universal binary.