-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Allow accessing the regular mine/event bus from salt-ssh #65646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
837e249
to
892de82
Compare
dwoz
approved these changes
Dec 12, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mine
wrapper to access the regular minepublish
wrapper to access the regular event busWhat issues does this PR fix or reference?
Fixes: #40943
Fixes: #65645
Note:
x509.certificate_managed
state work on SSH minions. This is not the case. Thepublish
wrapper can be used to emulate its behavior somewhat though by writing a wrapper for thex509
execution module.arg
topublish.publish
for SSH minions just crashes:{'retcode': 1, 'stderr': 'Traceback (most recent call last):\n File "<string>", line 2, in <module>\n File "<string>", line 427, in <module>\n File "<string>", line 384, in main\nAttributeError: \'int\' object has no attribute \'startswith\'\n', 'stdout': '/usr/bin/scp\n'}
Previous Behavior
salt-ssh and regular Salt are strictly separated, except during pillar rendering
New Behavior
Data from regular Salt can be accessed in salt-ssh
Merge requirements satisfied?
Commits signed with GPG?
Yes