Stop websockets from disconnecting immediately #63062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce websockets finish early
|
@dwoz This should be ready then |
dwoz
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes a check introduced here that was part of a patch to solve a memory leak (see the issue here. The regression test shows that there is no leak even after removing the previous patch.
Also, after a patch from about 5 years ago (I believe this one), the tag_map wasn't being properly cleaned up and was growing to be massive if a lot of calls to the API happened. That has been resolved.
What issues does this PR fix or reference?
Fixes: #59183
Previous Behavior
Websockets closed immediately, and the tag map leaked memory.
New Behavior
The connection remains open, and we have a properly cleaned tag map.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes