Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix salt ssh's extra-filerefs #61014

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix salt ssh's extra-filerefs #61014

merged 1 commit into from
Oct 11, 2021

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Oct 8, 2021

What does this PR do?

  • Fix salt-ssh extra-filerefs
  • Add a test for salt-ssh when extra-filerefs is needed.

What issues does this PR fix or reference?

Fixes: #60003

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@dwoz dwoz requested a review from a team as a code owner October 8, 2021 00:14
@dwoz dwoz requested review from krionbsd and removed request for a team October 8, 2021 00:14
@dwoz dwoz changed the base branch from master to freeze October 8, 2021 00:14
@dwoz dwoz changed the title Issue/freeze/60003 Fix salt ssh's extra-filerefs Oct 8, 2021
@dwoz dwoz mentioned this pull request Oct 8, 2021
Closed
@dwoz dwoz force-pushed the issue/freeze/60003 branch from 844f396 to 960c24a Compare October 8, 2021 00:22
@Ch3LL Ch3LL added the Silicon v3004.0 Release code name label Oct 8, 2021
Ch3LL
Ch3LL suggested changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs a changelog

@dwoz
Copy link
Contributor Author

dwoz commented Oct 8, 2021

just

There is already a changelog for this. See my comment in the PR description.

@dwoz dwoz requested a review from Ch3LL October 9, 2021 18:53
@Ch3LL Ch3LL merged commit 3525300 into saltstack:freeze Oct 11, 2021
@myii myii mentioned this pull request Oct 12, 2021
Open
@max-arnold max-arnold mentioned this pull request Oct 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

@krionbsd krionbsd Awaiting requested review from krionbsd krionbsd is a code owner automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
Silicon v3004.0 Release code name
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] salt-ssh support for extra_filerefs in Saltfile is broken
2 participants
@dwoz @Ch3LL