Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mac build scripts #56435

Merged
merged 8 commits into from
Mar 24, 2020
Merged

Conversation

twangboy
Copy link
Contributor

What does this PR do?

Roll back #56417
Building on 10.14 seems to fix most of the issues

What issues does this PR fix or reference?

#56417

Tests written?

NA

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner March 23, 2020 20:00
@ghost ghost requested a review from waynew March 23, 2020 20:00
@Ch3LL Ch3LL added the v3000.1 vulnerable version label Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #56435 into master will decrease coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #56435      +/-   ##
==========================================
- Coverage    18.4%   17.41%      -1%     
==========================================
  Files        1271     1234      -37     
  Lines      249324   232701   -16623     
  Branches    54383    50760    -3623     
==========================================
- Hits        45894    40528    -5366     
+ Misses     199443   189269   -10174     
+ Partials     3987     2904    -1083
Flag Coverage Δ
#archlts 16.7% <ø> (+0.31%) ⬆️
#centos7 24.42% <ø> (-0.86%) ⬇️
#cloud ?
#proxy 24.48% <ø> (+0.03%) ⬆️
#py2 17.22% <ø> (-7.79%) ⬇️
#py3 17.08% <ø> (-1.05%) ⬇️
#runtests 17.41% <ø> (-1%) ⬇️
#ubuntu1604 24.42% <ø> (+0.02%) ⬆️
#zeromq 17.41% <ø> (+0.06%) ⬆️
Impacted Files Coverage Δ
salt/ext/tornado/httpclient.py 22.27% <0%> (-42.36%) ⬇️
salt/ext/tornado/tcpclient.py 24.52% <0%> (-41.51%) ⬇️
salt/utils/xmlutil.py 13.63% <0%> (-40.91%) ⬇️
salt/ext/tornado/simple_httpclient.py 17.11% <0%> (-31.84%) ⬇️
salt/utils/vt.py 10.75% <0%> (-28.7%) ⬇️
salt/utils/aws.py 15.71% <0%> (-27.5%) ⬇️
salt/ext/tornado/http1connection.py 12.8% <0%> (-26.09%) ⬇️
salt/utils/cloud.py 9.31% <0%> (-23.25%) ⬇️
salt/utils/openstack/pyrax/__init__.py 55.55% <0%> (-22.23%) ⬇️
salt/cloud/__init__.py 7.77% <0%> (-20.99%) ⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a5bd8...9eec41b. Read the comment docs.

@dwoz dwoz merged commit 4d2bc70 into saltstack:master Mar 24, 2020
@twangboy twangboy deleted the update_mac_build_scripts branch May 26, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3000.1 vulnerable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants