Ensure version.py included before we install

[Ch3LL]

What does this PR do?

Ensures _version.py included before we run install when running python setup.py install

What issues does this PR fix or reference?

#56415

Previous Behavior

_version.py would not be included in the build if you run python setup.py install. This is because setuptools does not call run_command('build'), whereas distutils did when we did an install and we recently migrated to setuptools.

New Behavior

_version.py included and salt --version reporting correctly.

Tests written?

Yes

Commits signed with GPG?

Yes

[marbx]

@Ch3LL, I suspect another root cause.

salt/version.py contains "tag describe":

git describe --tags --first-parent --match v[0-9]* --always

I think this was appropriate for the abandoned "develop" / multi releases git scheme.

Problem with the current "master" git scheme is that "tag describe" returns from head

v3000_docs-33-g4249d7f1e1

This is maybe is the last tag, but it should be 3001, as @frogunder noted 26 days ago.

When I execute simply git describe (on git head master), I get

v3000.1-206-g4249d7f1e1

When I build the Windows installer (on git head master) with the current "tag describe" in salt/version.py I read

build :: Install Current Version of salt...
---------------------------------------------------------------------
3000-33-g4249d7f1e1

When I build the Windows installer with modified and simple git describe in salt/version.py I read

build :: Install Current Version of salt...
---------------------------------------------------------------------
3000.1-206-g4249d7f1e1

Though I fail to understand where the file content for _version.py comes from, I assume it is "git describe" and would I suggest that version.py uses it too.

I wrote to @twangboy on Slack before.

[Ch3LL]

@markuskramerIgitt would you mind opening a new issue with these details. This is breaking because we have never before used a <version>_docs tag.

[marbx]

Hi @Ch3LL , I opened #56634

By the way, I looked for and found other <version>_docs tags.