Changed StrictVersion checking of setuptools to LooseVersion #56218
Conversation
ghost
requested a review
from 
|
Oh nice, i didnt catch that. Will do
Hey should i open a separate issue asking about if you all are open to setting up black/precommit to auto format and check for stuff like this automatically?
Sent from ProtonMail mobile
…-------- Original Message --------
On Feb 26, 2020, 7:27 AM, Pedro Algarvio wrote:
@s0undt3ch requested changes on this pull request.
As Megan pointed out. Let's remove the unused import.
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#56218?email_source=notifications&email_token=ABTCBHXNQEUEHG4F2OAUVITREZ33ZA5CNFSM4KY4NR62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXAI4ZY#pullrequestreview-364940903), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABTCBHXAB3647TJXLK2TIELREZ33ZANCNFSM4KY4NR6Q).
|
|
We will |
|
Will 3000.1 be the first merge to master? |
I'm not sure what you are asking? 3000.1 release will be tagged from the master branch if that is what you are asking. |
|
Ah sorry I thought you all were going to do a mass merge of all the items marked for 3000.1 and then tag it, I must misunderstand something, I'll re read the new merge strategy doc. Thanks again |
|
Oh no worries, i think i just misunderstood the question. This is the project board we are using to track what issues need to get in for 3000.1, looks like your issue is under commit, so looks like we will get this one in :) |
|
errr sometimes it helps to include links you refer to lol https://github.com/saltstack/salt/projects/8 |
|
Totally, I got what you meant. Yes that was the board I was thinking of also :) thanks |
What does this PR do?
Fixes an installation issue in conda envs
What issues does this PR fix or reference?
#56184
Previous Behavior
Install doesnt work
New Behavior
Install works
Tests written?
No
Commits signed with GPG?
No... I know I should know better it's on my list