Allows use of inline powershell for cmd.script args #56197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
lorengordon
force-pushed
the
file-or-no-file
branch
from
77756fe
to
4a835db
Compare
lorengordon
force-pushed
the
file-or-no-file
branch
4 times, most recently
from
9b6d31c
to
c660a6d
Compare
Fixes #356195
lorengordon
force-pushed
the
file-or-no-file
branch
from
c660a6d
to
fcd1699
Compare
twangboy
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Using powershell.exe with
-Filewhen the source shell is cmd treats all args as literal strings, which prevents usage of inline powershell. This patch just removes the-Fileargument, which still works with a script, but allows powershell to process any inline powershell that may be passed to one of the script args.What issues does this PR fix or reference?
Fixes #56195
Previous Behavior
Args passed to cmd.script with shell=powershell were treated as literal strings
New Behavior
Args are processed by powershell
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes