Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saltversioninfo grain for new version #56082

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Fix saltversioninfo grain for new version #56082

merged 3 commits into from
Mar 10, 2020

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Feb 6, 2020 •
edited
Loading

Previous Behavior

(salt)  ch3ll@thecakeisalie  ~/git/salt  ➦ 81eb152643  salt-call --local grains.get saltversioninfo
local:
    - 3000
    - 0
    - None
    - 0

New Behavior

(salt)  ch3ll@thecakeisalie  ~/git/salt   ver_grains  salt-call --local grains.get saltversioninfo
local:
    - 3000

Fixes Issue

#56228

Tests written?

Yes

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from a team as a code owner February 6, 2020 20:59
@ghost ghost requested a review from Akm0d February 6, 2020 20:59
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Feb 6, 2020

Please dont merge this yet, found a couple other property methods i need to update

@Ch3LL Ch3LL changed the title Fix saltversioninfo grain for new version [WIP] Fix saltversioninfo grain for new version Feb 6, 2020
@Ch3LL Ch3LL requested a review from s0undt3ch February 7, 2020 23:26
@Ch3LL Ch3LL changed the title [WIP] Fix saltversioninfo grain for new version Fix saltversioninfo grain for new version Feb 10, 2020
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Feb 10, 2020

ready for review/merge

@Ch3LL
Copy link
Contributor Author

Ch3LL commented Feb 19, 2020

ping @s0undt3ch can you re-review this?

@Ch3LL Ch3LL mentioned this pull request Feb 21, 2020
Closed
@Ch3LL Ch3LL added v3000.1 vulnerable version Merge Ready labels Mar 4, 2020
@dwoz dwoz merged commit 9f27caa into saltstack:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@twangboy twangboy twangboy approved these changes

@Akm0d Akm0d Awaiting requested review from Akm0d

Assignees
No one assigned
Labels
v3000.1 vulnerable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ch3LL @waynew @s0undt3ch @twangboy @dwoz