Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use packaged json module for ThreadsafeProxy #55660

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Use packaged json module for ThreadsafeProxy #55660

merged 3 commits into from
Dec 19, 2019

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Dec 16, 2019 •
edited
Loading

What does this PR do?

Separate json lib import changes from #54878
This is in preparation for the threadsafe loader PR

@Akm0d Akm0d requested a review from a team as a code owner December 16, 2019 19:40
@ghost ghost requested a review from DmitryKuzmenko December 16, 2019 19:40
@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 16, 2019

re-run full debian8

@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 16, 2019

re-run full centos6

s0undt3ch
s0undt3ch reviewed Dec 17, 2019
View reviewed changes
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we're maintaining code like:

from salt.utils.json import loads, dumps

As opposed to something like, for example:

import salt.utils.json as json

x = json.loads()
y = json.dumps()

@Akm0d Akm0d requested a review from dwoz December 17, 2019 07:36
@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 17, 2019

re-run full debian8

Akm0d added a commit to Akm0d/salt that referenced this pull request Dec 17, 2019
@Akm0d
isolated salt.utils.json changes to saltstack#55660
6e3523d
@Akm0d Akm0d self-assigned this Dec 18, 2019
@Akm0d Akm0d added the Core relates to code central or existential to Salt label Dec 18, 2019
@Akm0d Akm0d added this to the Approved milestone Dec 18, 2019
@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 18, 2019

re-run full windows2019

@dwoz dwoz merged commit 6c238d0 into saltstack:master Dec 19, 2019
@Akm0d Akm0d deleted the use_packaged_jsonlibs branch December 19, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@DmitryKuzmenko DmitryKuzmenko Awaiting requested review from DmitryKuzmenko

@dwoz dwoz Awaiting requested review from dwoz

Assignees

@Akm0d Akm0d

Labels
Core relates to code central or existential to Salt
Projects
None yet
Milestone
Approved
Development

Successfully merging this pull request may close these issues.
4 participants
@Akm0d @s0undt3ch @garethgreenaway @dwoz