Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure refresh and refresh_db both work in aptpkg #55643

Merged
merged 3 commits into from
Dec 21, 2019

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Dec 13, 2019

What does this PR do?

We do not actually want to deprecate refresh_db to ensure users to not have to update their states. This PR is removing the deprecation warning and updating the docs to urge users to user the preferred argument.

What issues does this PR fix or reference?

#49418

Previous Behavior

deprecation warning when using refresh_db

New Behavior

deprecation warning removed and docs added

Tests written?

No

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from a team as a code owner December 13, 2019 23:11
@ghost ghost requested a review from dwoz December 13, 2019 23:11
@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8d8e4cf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55643   +/-   ##
=========================================
  Coverage          ?    38.9%           
=========================================
  Files             ?     1467           
  Lines             ?   260318           
  Branches          ?    56410           
=========================================
  Hits              ?   101238           
  Misses            ?   147980           
  Partials          ?    11100
Flag Coverage Δ
#macosxmojave 37.48% <ø> (?)
#py2 37.48% <ø> (?)
#py3 37.81% <ø> (?)
#runtests 38.9% <ø> (?)
#ubuntu1804 37.81% <ø> (?)
#zeromq 38.9% <ø> (?)
Impacted Files Coverage Δ
salt/modules/aptpkg.py 44.4% <ø> (ø)
salt/states/pkgrepo.py 7.74% <ø> (ø)

@Ch3LL Ch3LL added the ZRELEASED - Neon retired label label Dec 20, 2019
@dwoz dwoz merged commit 42b8d42 into saltstack:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRELEASED - Neon retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants