Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service.reload in gentoo_service module #55452

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Fix service.reload in gentoo_service module #55452

merged 3 commits into from
Dec 3, 2019

Conversation

vulnbe
Copy link
Contributor

@vulnbe vulnbe commented Nov 27, 2019

What does this PR do?

It fixes gentoo_service.py module.

What issues does this PR fix or reference?

gentoo_service module has reload_ function but service.reload doesn't work because there is no 'reload' alias defined.

Tests written?

I believe the existing tests are enough for such changes.

Commits signed with GPG?

Yes

@vulnbe vulnbe requested a review from a team as a code owner November 27, 2019 22:38
@ghost ghost requested a review from garethgreenaway November 27, 2019 22:38
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vulnbe Please fix the linter issue

@vulnbe
Copy link
Contributor Author

vulnbe commented Dec 3, 2019

@dwoz done.

@dwoz dwoz merged commit d418dac into saltstack:master Dec 3, 2019
@vulnbe vulnbe deleted the origin/master branch December 3, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants