Fix virt.get_hypervisor() #55351
Merged
Fix virt.get_hypervisor() #55351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Akm0d
added
Confirmed
|
Even for a simple change like moving a parenthesis a unit test is necessary so that we don't have regressions. I can help whip that up when I'm done triaging for the day 👍 |
virt.get_hypervisor resulted in:
AttributeError: module 'salt.loader.dev-srv.tf.local.int.module.virt' has no attribute '_is_{}_hyper'
This was due to missplaced parenthese.
cbosdo
force-pushed
the
master-virt-hypervisor-fix
branch
from
93d58c2
to
1d3f7d6
Compare
Done... not sure the test is super useful though ;) |
Akm0d
removed
the
Needs-Testcase
|
Thank you so much! |
|
re-run full macosxmojave |
|
re-run full amazon1 |
|
re-run full tornado |
s0undt3ch
approved these changes
Nov 25, 2019
Akm0d
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
virt.get_hypervisor resulted in:
This was due to missplaced parenthese.
What issues does this PR fix or reference?
No issue filed for this yet.
Previous Behavior
calling
virt.get_hypervisorwas throwing the error:New Behavior
calling
virt.get_hypervisornow returns the actual valueTests written?
No - would require to abstract the
virt._is_*_hyperfunctions and thus only test one line of rather simple code... even though that one contained a misplaced parenthese.Commits signed with GPG?
Yes