Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virt.pool_capabilities function #55346

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Nov 18, 2019

What does this PR do?

Not all storage backends are supported for a given libvirt hypervisor. For the user
to know what is supported and what is not expose the recently added
libvirt function providing pool capabilities.

For older libvirt version, let's craft data that are reasonable by
adding a computed flag to warn these data may not be 100% accurate.

What issues does this PR fix or reference?

Tests written?

Yes

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from a team as a code owner November 18, 2019 14:42
@ghost ghost requested a review from dwoz November 18, 2019 14:42
@cbosdo cbosdo force-pushed the master-pool-capabilities branch 3 times, most recently from 34f6496 to cb687a4 Compare November 18, 2019 17:30
@Akm0d Akm0d added the Feature new functionality including changes to functionality and code refactors, etc. label Nov 20, 2019
@Akm0d Akm0d added this to the Approved milestone Nov 20, 2019
@dwoz
Copy link
Contributor

dwoz commented Dec 2, 2019

@cbosdo Can you please resolve the merge conflict?

@cbosdo
Copy link
Contributor Author

cbosdo commented Dec 3, 2019

@cbosdo Can you please resolve the merge conflict?

done

@cbosdo cbosdo force-pushed the master-pool-capabilities branch 2 times, most recently from f4a627a to b178aa4 Compare December 20, 2019 08:19
@cbosdo
Copy link
Contributor Author

cbosdo commented Dec 20, 2019

rebased on master

@cbosdo
Copy link
Contributor Author

cbosdo commented Dec 23, 2019

rebased on master

Not all storage backends are supported for a given libvirt hypervisor. For the user
to know what is supported and what is not expose the recently added
libvirt function providing pool capabilities.

For older libvirt version, let's craft data that are reasonable by
adding a computed flag to warn these data may not be 100% accurate.
@dwoz dwoz merged commit 026f136 into saltstack:master Dec 27, 2019
@cbosdo cbosdo deleted the master-pool-capabilities branch December 30, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants