Checking for jid before returning data #55216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems raw can have returns for the same minion, but an other job. In order to not return resutls from the wrong job, we need to check for the jid.
ghost
requested a review
from 
brejoc
changed the title
|
@Ch3LL Could you please take a look here? #52459 (comment) |
Ch3LL
approved these changes
Dec 17, 2019
|
ping @brejoc looks like there is a conflict. mind resolving that? if not I can help out |
|
@Ch3LL Thanks for looking into this again! Seems like the conflicting imports where just removed, so I did the same here. Conflict is solved. Let's see if the tests are still passing for this. |
|
@dwoz Thanks for taking care of this! 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Seems raw can have returns for the same minion, but an other job. In order to not return resutls from the wrong job, we need to check for the jid.
What issues does this PR fix or reference?
#50927
This is the successor of #52459.
Previous Behavior
Wrong job results might be returned. Please take a look at #50927
New Behavior
Only the correct jobs results should be returned.
Tests written?
Yes
Commits signed with GPG?
Yes