pool deleted state #55200
Merged
pool deleted state #55200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Note that this PR is based on PR #54475 |
cbosdo
force-pushed
the
master-pool-deleted-state
branch
2 times, most recently
from
d3b3112
to
75da553
Compare
There are two reasons to remove this parameter without deprecating it: * the meaning has been mistakenly inversed * fast=True will raise an exception for every libvirt storage backend since that flag has never been implemented in any of those. Fixes issue saltstack#54474
cbosdo
force-pushed
the
master-pool-deleted-state
branch
from
75da553
to
caa4f52
Compare
The new virt.pool_deleted state takes care of removing a virtual storage pool and optionally the contained volumes.
cbosdo
force-pushed
the
master-pool-deleted-state
branch
from
caa4f52
to
d2194f0
Compare
dwoz
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
virt.pool_deletedstate to use to ensure a virtual storage pool and optionally its volumes are deleted. This state handles the various libvirt storage backends specific implementations to avoid triggering exceptions if an function is not implemented on the libvirt side.Tests written?
Yes
Commits signed with GPG?
Yes