(Backport 51871) cmdmod: add 'binds' parameter in run_chroot #54996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynew
reviewed
Nov 6, 2019
|
@aplanas thanks for adding the tests and getting the backport. Looks like this is out of date with I know at least one of these failures is a flaky test that we've been working on, that shouldn't block the PR from merging. Hopefully with the rebase we should see that test pass. |
aplanas
force-pushed
the
backport_51871
branch
from
284ffc0
to
48c479f
Compare
ghost
requested a review
from (cherry picked from commit aeceb1d)
Sometimes we want to export directories from the system to the chroot environment. For example, some services will require the presence of /run inside the chroot, to request some PID information. This patch add a new 'binds' parameter in the run_chroot function, that will export those system directories into the chroot. (cherry picked from commit b6a4394)
aplanas
force-pushed
the
backport_51871
branch
from
48c479f
to
933fba5
Compare
dwoz
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes we want to export directories from the system to the
chroot environment. For example, some services will require the
presence of /run inside the chroot, to request some PID information.
This patch add a new 'binds' parameter in the run_chroot function,
that will export those system directories into the chroot.
Tests written?
Yes, added in this PR
(backport #51871, already merged in develop)