Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Backport 50834) Add disk_set and disk_toggle functions, and update valid partition flags #54966

Closed
wants to merge 2 commits into from
Closed

(Backport 50834) Add disk_set and disk_toggle functions, and update valid partition flags #54966

wants to merge 2 commits into from

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Oct 11, 2019 •
edited
Loading

What does this PR do?

  • Add disk_set and disk_toggle parted functions
  • Update the list of valid flags for partitions, based on parted 3.2

Tests written?

Yes

(backport #50834 already merged in develop)

@aplanas aplanas changed the title (Backport 50834) Add disk_set and disk_toggle functions, and update valid partition flags (Backport 50834, 51704) Add disk_set and disk_toggle functions, and update valid partition flags Oct 11, 2019
@dwoz dwoz requested a review from a team as a code owner November 20, 2019 07:40
@ghost ghost requested a review from twangboy November 20, 2019 07:40
@aplanas aplanas mentioned this pull request Dec 5, 2019
Merged
@aplanas aplanas changed the title (Backport 50834, 51704) Add disk_set and disk_toggle functions, and update valid partition flags (Backport 50834) Add disk_set and disk_toggle functions, and update valid partition flags Dec 5, 2019
@aplanas
Copy link
Contributor Author

aplanas commented Dec 5, 2019

I split the backports here and in #55515

@waynew
Copy link
Contributor

waynew commented Jan 15, 2020

Looks like this is already included in #55515 - let me know if that's not correct

@waynew waynew closed this Jan 15, 2020
@aplanas aplanas deleted the backport_50834 branch January 16, 2020 09:10
@aplanas
Copy link
Contributor Author

aplanas commented Jan 16, 2020

Indeed, thanks!

@waynew waynew removed the master-port label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy Awaiting requested review from twangboy

Assignees

@Akm0d Akm0d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aplanas @waynew @garethgreenaway @Akm0d