(Backport 50302) cmd: Add root parameter for wait and run states #54956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
force-pushed
the
backport_50302
branch
from
f3728fb
to
a84615b
Compare
waynew
reviewed
Nov 6, 2019
aplanas
force-pushed
the
backport_50302
branch
from
a84615b
to
4041e46
Compare
ghost
requested a review
from Add root parameter for a chroot environment to `wait` and `run` states. In the case of `run`, we delegate the execution to the `run_chroot` module. (cherry picked from commit cd7b5b2)
aplanas
force-pushed
the
backport_50302
branch
from
4041e46
to
5947392
Compare
dwoz
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add root parameter for a chroot environment to
waitandrunstates. In the case of
run, we delegate the execution to therun_chrootmodule.Tests written?
Yes. Were missing in develop, added for master
(backport #50302, already merged in develop)