-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple LGPO Fixes #54896
Merged
Merged
Multiple LGPO Fixes #54896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcmarrow
approved these changes
Oct 4, 2019
s0undt3ch
approved these changes
Oct 4, 2019
re-run full all |
twangboy
changed the title
Fix comparing integer values (LGPO)
WIP: Multiple LGPO Fixes
Oct 16, 2019
ghost
requested a review
from Ch3LL
October 23, 2019 15:58
@twangboy looks like this needs a bit of a rebase... |
twangboy
force-pushed
the
fix_win_lgpo
branch
from
November 25, 2019 17:37
fa9d359
to
a412c89
Compare
twangboy
force-pushed
the
fix_win_lgpo
branch
4 times, most recently
from
January 4, 2020 23:18
7b99e60
to
6b9ad20
Compare
Codecov Report
@@ Coverage Diff @@
## master #54896 +/- ##
=========================================
Coverage ? 18.76%
=========================================
Files ? 825
Lines ? 176254
Branches ? 37929
=========================================
Hits ? 33059
Misses ? 140553
Partials ? 2642
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #54896 +/- ##
=========================================
Coverage ? 18.76%
=========================================
Files ? 825
Lines ? 176254
Branches ? 37929
=========================================
Hits ? 33059
Misses ? 140553
Partials ? 2642
|
Rebase master
There was a bug with `text` type strings that were semicolon delimited. It would only return the first value Add many tests
Add some missing loader_module methods in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue when comparing integer values in the win_lgpo state module. Integer values weren't being compared and therefore always returning not matching.
Fix some stacktraces that are showing up in Windows logs due to missing virtual functions in some salt utils
Change noisy debug statements in the win_lgpo module to trace statements
Fix issue with incorrect registry type for ScRemoveOption
Reverts changes in 0108bcd that were causing issues with policies where the registry entries didn't match the case in the admx/adml files
What issues does this PR fix or reference?
Found fixing locke issues
Tests written?
Yes
Commits signed with GPG?
Yes