Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state.show_states when sls file missing in top file #54785

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Sep 26, 2019

What does this PR do?

When a sls file is defined in a top.sls file that is missing a TypeError was raised when using state.show_states. This PR ensures we do not stacktrace and handle this situation

What issues does this PR fix or reference?

#54758

Previous Behavior

Passed invalid arguments: string indices must be integers.

Usage:

    Returns the list of states that will be applied on highstate.

    CLI Example:

    .. code-block:: bash

        salt '*' state.show_states

    .. versionadded:: 2019.2.0

New Behavior

local:
       - No matching sls found for 'cloud' in env 'base'

Tests written?

Yes

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from waynew September 26, 2019 23:08
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Sep 27, 2019

re-run full all

@dwoz dwoz merged commit b90c3f2 into saltstack:2019.2.1 Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants