cloud/tencentcloud: add tencentcloud support for salt-cloud #54518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
likexian
changed the title
|
Hello, The codeclimate check really have to fix? The refer: https://codeclimate.com/github/saltstack/salt/pull/54518#issues |
|
@likexian nope - I was one of the last holdouts on CC, but I haven't actually seen it provide useful, actionable information yet. |
Akm0d
approved these changes
Sep 18, 2019
Merged
|
Closing because these commits were cherry-picked into a PR against master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add
tencentcloudsupport for salt-cloud.Tencent Cloud is a secure, reliable and high-performance cloud compute service provided by Tencent. It is the 2st largest Cloud Provider in China.
What issues does this PR fix or reference?
None
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.