Git pillar update interval #53621
Merged
Git pillar update interval #53621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know how to write tests for this... |
|
@twangboy @dwoz @terminalmage @cachedout Please review. |
DmitryKuzmenko
approved these changes
Jun 27, 2019
|
I'm not sure if there's any good way of automating the test, but a meaningful test would be to update the interval to something ridiculously short (1s? 3s?) and simply verify that it triggers an update the appropriate number of times within an interval. |
sathieu
force-pushed
the
git_pillar_update_interval
branch
from
1278266
to
d2c2535
Compare
sathieu
force-pushed
the
git_pillar_update_interval
branch
3 times, most recently
from
20bfbec
to
e2f24c9
Compare
dwoz
requested changes
Dec 21, 2019
… data can be collected less frequently than the main loop_interval timer allows
Similar to gifs_update_interval
sathieu
force-pushed
the
git_pillar_update_interval
branch
from
fa3589d
to
a1844cf
Compare
|
@dwoz thanks! |
This was referenced Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for new config option
git_pillar_update_intervalso git_pillar data can be collected less frequently than the mainloop_intervaltimer allowsWhat issues does this PR fix or reference?
This is based on work on #52274 by @Tanoti
Previous Behavior
Git pillar remotes would be checked using the
loop_intervaltimer value (e.g. every 60 seconds).New Behavior
Git pillar remotes can be checked using a different interval to the
loop_interval. For example, if the git pillar data is not likely to change very often then a higher value such as 300 seconds could be used which would reduce the load on the git repo server by a factor of five.Tests written?
No
Commits signed with GPG?
Yes