(Backport 52699) btrfs: Add properties state #53439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
approved these changes
Jun 14, 2019
aplanas
force-pushed
the
backport_52699
branch
from
d893bd1 to
a245d62
Compare
ghost
requested a review
from 
aplanas
force-pushed
the
backport_52699
branch
from
a245d62 to
c5d6391
Compare
The decorator can work without a device (so nothing can be mounted) Also the traceback removed in PR#51205 is re-added, to show the internal exception from the decorated code. (cherry picked from commit adafb369d37a0b33b2b2e3e5c17e1388de34958b)
We can set via `btrfs property` command some properties. This command
is used in the btrfs execution module.
The current state will leverate this code to make sure that some
properties al set or unset in a safe mode.
For example:
set_property_ro_/:
- name: /
- device: /dev/sda1
- use_defaults: yes
- ro: yes
(cherry picked from commit e3d14dffc8991bd453701c4f4b8770d961a769b6)
(cherry picked from commit d2280f060faef109ea439c539472d159b7dfb172)
aplanas
force-pushed
the
backport_52699
branch
from
c5d6391 to
44ca8ba
Compare
|
Rebased on master in #52699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We can set via
btrfs propertycommand some properties. This commandis used in the btrfs execution module.
The current state will leverate this code to make sure that some
properties al set or unset in a safe mode.
Tests written?
Yes
(backport #52699)