Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 51706) grains/core: ignore HOST_NOT_FOUND errno in fqdns() #53438

Closed
wants to merge 1 commit into from

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Jun 11, 2019

Also ignore NO_DATA errors, as this imply an empty field

Fixes #52788

(backport #51706)

@aplanas aplanas changed the title grains/core: ignore HOST_NOT_FOUND errno in fqdns() (Backport 51706) grains/core: ignore HOST_NOT_FOUND errno in fqdns() Jun 11, 2019
@aplanas aplanas force-pushed the backport_51706 branch 2 times, most recently from c1a395e to 0315a25 Compare August 2, 2019 14:04
@aplanas aplanas requested a review from a team as a code owner August 23, 2019 08:00
@ghost ghost requested a review from garethgreenaway August 23, 2019 08:00
@waynew
Copy link
Contributor

waynew commented Aug 28, 2019

Did I see some tests with this change on one of the other PRs?

Also ignore NO_DATA errors, as this imply an empty field

Fixes saltstack#52788

(cherry picked from commit 816ee23bb11a5bca3930f8e98166f498b5bcee33)
@aplanas
Copy link
Contributor Author

aplanas commented Oct 14, 2019

Rebased on master in #51706

@aplanas aplanas closed this Oct 14, 2019
@aplanas aplanas deleted the backport_51706 branch October 14, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants