Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mount: fix remount when fstype is not set #52712

Merged
merged 1 commit into from
Apr 29, 2019
Merged

mount: fix remount when fstype is not set #52712

merged 1 commit into from
Apr 29, 2019

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Apr 26, 2019

What does this PR do?

Fix the remount command when fstype is not set.

Also fix a wrong rebase that happens somewhere when the big forward port dragged changed from the past.

dwoz
dwoz requested changes Apr 27, 2019
View reviewed changes
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aplanas please make sure this change has test coverage.

@aplanas
Copy link
Contributor Author

aplanas commented Apr 29, 2019

@dwoz Yes sorry. Done.

@dwoz dwoz merged commit ea784e7 into saltstack:develop Apr 29, 2019
@aplanas aplanas deleted the fix_remount branch May 2, 2019 08:40
@aplanas aplanas mentioned this pull request Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aplanas @dwoz