Proposed update to resolve saltstack/salt#52538 #52641
Conversation
Since refresh_db is a costly operation we should have the option of not calling that Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
Pygit2 version 0.26.2 added support for pruning when fetching. In this way Pygit2 provider will no longer need to leverage git commanand line utility for pruning the remote. Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
Pkgrepo state module is using a named argument when calling pkg.del_repo. Change the name of the argument from 'alias' to 'repo' and update all other functions to be consistent on naming. Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
python exposes an nt.environ for case insensitive environment behavior that is native to windows; so it makes sense to use this instead of os.environ to avoid enexpected behavior and failure. further detail: https://bugs.python.org/issue28824
Simplify IPCClient and prevent corrupt messages
…ents Use uncommon item in mine delete test
Backport #49984 into 2018.3
2018.3 backport #52472 modules.cmdmod: handle windows environ better
When the source is procedurally generated (e.g. from the result of a remote execution function call), and that source ends up being an empty string or some other invalid value, the call to `file.source_list` will return a path of `None` which will cause a `TypeError` later on when we try to run a urlparse on it.
Ignore retcode when checking FS type
Fix test_xen_virtual on kernels with no Xen support
Remove outdated thorium warning: Solves #52557
Fix race condition in event assertion
Create nox lint virtualenvs before running them
Update test_schema to mirror the new ValidationErrors in 3.0.0
Explicitly close IPC connections
[2017.7] Merge forward from 2017.7.9 to 2017.7
Conflicts: * tests/integration/__init__.py
[2018.3] Merge forward from 2017.7 - Includes switch to nox
|
Hi @que5o thanks for the PR! Pretty sure this looks good - is this issue just in develop, or does it also exist against 2018? If so, if you rebase & retarget your PR against 2018.3, we will merge it forward to 2019.2 & develop. Also, would it be possible to write some tests for this? |
|
Yes looks like this exists in 2018.3 branch. I'll look into how to re-base the PR. I'll also look into adding a some unit testing |
Simply remove reading the target csv file in binary format
|
I f****d this all up. Since it's a one letter change, I'm going to redo the pull request from scratch. The original PR gets to live on to display my shame. |
|
No harm no foul ;) When I first started with Git I don't even know what I did to completely hork up a repo I was working in. Someone walked me through, step by step, to rewrite my history and make things better. |
|
I have submitted a new PR to replace this mess: |
Simply remove reading the target csv file in binary format
What does this PR do?
resolves issue with csvpillar.py attempting to read csv file in binary format instead of text
What issues does this PR fix or reference?
#52538
Previous Behavior
Reads target csv file from disk in binary format
New Behavior
Reads target csv file in text format
Tests written?
No
Commits signed with GPG?
No