Address inconsistent usage of get_xml function in virt execution module.
#52574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure thing, at the earliest I'll have time to write them tomorrow, though. |
dwoz
approved these changes
Apr 18, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
Akm0d
added
has master-port
dwoz
added a commit
that referenced
this pull request
Nov 12, 2019
[master] Porting #52574 to master
admd
pushed a commit
to admd/salt-1
that referenced
this pull request
Jan 27, 2020
* Porting PR saltstack#52574 to 2019.2.1 * Partly revert 4ce0bc5 to match upstream's fix
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Apr 22, 2020
* Porting PR saltstack#52574 to 2019.2.1 * Partly revert 4ce0bc5 to match upstream's fix
meaksh
pushed a commit
to meaksh/salt
that referenced
this pull request
Apr 22, 2020
* Porting PR saltstack#52574 to 2019.2.1 * Partly revert 4ce0bc5 to match upstream's fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempts to fix inconsistent usage of
get_xml()in thevirtexecution module, introduced with commit0f5184c45cc962a1961166d9d6ee8c9522cf431bas part of PR #48736What issues does this PR fix or reference?
Fixes #52431
Tests written?
No
Commits signed with GPG?
No