Allow using salt modules in onlyif and unless

[gtmanfred]

What does this PR do?

Allow using salt modules in onlyif and unless

What issues does this PR fix or reference?

Implements #5050
Implements #51604

Previous Behavior

Can only use commands that run through cmd.retcode

New Behavior

Can use any salt module, and the result is determined by the trueish or falsish return of the module.

Tests written?

Yes

Commits signed with GPG?

Yes

[gtmanfred]

@saltstack/team-core can I get a review on this.

Thanks!
Daniel

[gtmanfred]

Ok, this should be good to merge 😄

[mchugh19]

This is pretty major and should get a shout out in the release notes too

[max-arnold]

@gtmanfred Unfortunately, this doesn't work consistently across all states and needs to be improved. The following states have their own mod_run_check implementations:

• states.git
• states.cmd
• states.macpackage
• states.file
• states.docker_container

This is where unless/onlyif get skipped: https://github.com/saltstack/salt/blob/develop/salt/state.py#L1955-L1957

I discovered this while trying to fix slots #53307

[mchugh19]

The following states have their own mod_run_check implementations

In glancing over those states, it's not immediately obvious why they have their own mod_run_check implementations? Would functionality change if they were just removed?

[gtmanfred]

They had unless and onlyif implementations before unless and onlyif was implemented, and unless/onlyif was a simpler implementation, so instead of having to make compatible changes for everything that the cmd.run onlyif did, i just let it be configured to be able to customize it.