Add utc_jid option for generating jids based on utc
#51126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to add a new test for this rather than adding code into the existing test? @saltstack/team-core thoughts? |
garethgreenaway
approved these changes
Jan 9, 2019
|
@garethgreenaway : Do I need to do something about the codeclimate issue? |
|
@msteed That codeclimate issue isn't a barrier to the PR being merged. |
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the
utc_jidconfig option (boolean) for generating jids based on UTC instead of local time.This is useful in SSE deployments where masters are in different timezones, so that jobs across the infrastructure can easily be sorted chronologically. The workaround is to set each master's clock to UTC.
What issues does this PR fix or reference?
#33309
Previous Behavior
Previous behavior is still available and enabled by default.
New Behavior
If
utc_jidisTrue, generate jids based on UTC instead of local time.Tests written?
Yes
Commits signed with GPG?
Yes