Update zabbix module to avoid exception #51038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen here https://www.zabbix.com/documentation/current/manual/api/reference/configuration/import Return values (boolean) Returns *true* if importing has been successful. Updated module to avoid 'Exception: object of type 'bool' has no len()' error.
|
@thechile can you find time to address the linter failures? |
mchugh19
reviewed
Jun 1, 2019
| @@ -2426,7 +2426,7 @@ def run_query(method, params, **kwargs): | |||
| ret = _query(method, params, conn_args['url'], conn_args['auth']) | |||
| if isinstance(ret['result'], bool): | |||
| return ret['result'] | |||
| return ret['result'] if ret['result'] else False | |||
| return ret['result'] if (ret['result'] == True or len(ret['result']) > 0) else False | |||
There was a problem hiding this comment.
To be lint proper this should probably read something like:
return ret['result'] if (salt.utils.data.is_true(ret['result']) or len(ret['result']) > 0) else False
|
I've ported this work to the master branch #55706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen here https://www.zabbix.com/documentation/current/manual/api/reference/configuration/import
This PR updates the module to avoid
Exception: object of type 'bool' has no len()error when using these type of Zabbix server API calls.Tests written?
No
Commits signed with GPG?
No