Feature: add migrate command to djangomod #50083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
suggested changes
Oct 17, 2018
There was a problem hiding this comment.
Welcome @jrbeilke! Thank you for submitting this fix and for writing those tests.
I have one documentation request. Can you add a .. versionadded:: Neon tag to the docs of this new function and also document all of the args/kwargs individually? Then we can give this another review.
|
Done and done! |
rallytime
approved these changes
Oct 17, 2018
gtmanfred
suggested changes
Oct 17, 2018
cachedout
reviewed
Oct 18, 2018
cachedout
approved these changes
Oct 22, 2018
|
@gtmanfred Can you re-review this please? |
gtmanfred
approved these changes
Oct 22, 2018
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for Django CLI's
migratecommand.The
syncdbcommand was deprecated in Django 1.7 in favor of a newmigratecommand (https://docs.djangoproject.com/en/2.1/releases/1.7/#schema-migrations), andsyncdbwas removed in Django 1.9What issues does this PR fix or reference?
#16674
Tests written?
Yes
Commits signed with GPG?
No