Fix token_file creation using external auth with salt-key #49223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachedout
approved these changes
Aug 21, 2018
|
@msciciel This is causing a related test to fail. Can you take a look? https://jenkinsci.saltstack.com/job/pr-kitchen-centos7-py3/job/PR-49223/2/ |
salt-key with '--auth' and '--make-token' options needs to create token file. Options 'token_file' which is used as a path for token file is provided by config.client_config.
msciciel
force-pushed
the
fix-salt-key-eauth-token-file
branch
from
52a1a1e
to
412015b
Compare
rallytime
approved these changes
Aug 23, 2018
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Dec 21, 2019
[master] Porting #49223 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix salt-key external auth using token file. salt-key with
--authand--make-tokenoptions needs to create token file. Optionstoken_filewhich is used as a path for token file is provided byconfig.client_config.What issues does this PR fix or reference?
#49222
Previous Behavior
New Behavior
Tests written?
No
Commits signed with GPG?
No