Add Azure DNS modules #47945
Add Azure DNS modules #47945
Conversation
rallytime
added
the
Needs-Testcase
|
The only unit tests I've done were heavily copy/pasted for (I believe) some |
|
Look at the Boto modules unit tests.
And I am available (not today,at a conference today) but to help in the
#develop channel on the community slack. Or in just pms there.
Thanks!
Daniel
…On Thu, Jun 7, 2018 at 10:48 PM, Nicholas Hughes ***@***.***> wrote:
The only unit tests I've done were heavily copy/pasted for (I believe)
some file module functionality. I don't really know where to start for
building Azure module unit tests from scratch. If someone can hold my hand
on this, I might try... but I'm not certain if I have the bandwidth to
complete them in a timely manner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#47945 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAssoSXH4IO-FBjILUeQ133D8EhcyXyXks5t6fQBgaJpZM4UYOt->
.
|
|
@nicholasmhughes Just a bump here. Were you able to get some tests going for this? |
|
@rallytime , nope... I tried to mess around and duplicate the tests from the Azure SDK, but failed. I don't really have time in the near future to make it happen. As far as this PR, it's been field tested and there are already a lot of Azure modules merged that don't have tests. We can either merge this or close it. I'd prefer the former obviously. 😉 |
salt/states/azurearm_dns.py
Outdated
|
|
||
| # Python libs | ||
| from __future__ import absolute_import | ||
| import json |
salt/states/azurearm_dns.py
Outdated
|
|
||
| # Salt libs | ||
| import salt.ext.six as six | ||
| import salt.utils |
|
@cachedout please check changes from review |
|
Merged! Thanks, @nicholasmhughes. This is great. |
sagetherage
added
has master-port
What does this PR do?
Add Azure DNS modules for crud operations on DNS zones and record sets.
What issues does this PR fix or reference?
N/A
Tests written?
No
Commits signed with GPG?
Yes