Orchestrate runner forces pillarenv and saltenv to None #43817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By inner workings of the
statemodulesget_optsfunction, the Orchestrate runner accidently forcespillarenvandsaltenvto None.This adds a preliminary check for that condition to prevent it, but honestly, this needs to be fixed somewhere else IMHO; this is an implementation gotcha likely to turn up in quite a few other places. Just have no clue where ;) maybe the
get_optsfunction?What issues does this PR fix or reference?
fixes #42568
Previous Behavior
Regardless of master config
pillarenvsetting, without specifying one on the CLI the runner will always have aNonerendered pillar.New Behavior
Conform to expected behaviour