Refactor SPM install to properly manage dependencies #31469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techhat It looks like some tests need to be addressed here. |
rallytime
added
the
pending-changes
|
@msteed, could you help me out with this? |
|
The remaining test failure seems unrelated; I'm pretty sure I didn't touch tornado in any way. |
cachedout
pushed a commit
that referenced
this pull request
Feb 25, 2016
Refactor SPM install to properly manage dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously optional and recommended dependencies were reported, but required dependencies were ignored. This refactor now properly supports required dependencies.
A side effect of this change is that multiple packages and package files may also be declared in a single command.
Ref #27562.
Ping @alexjennings, @meggiebot, @msteed, @plastikos.