Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engines support on Minions! #29245

Merged
merged 3 commits into from
Dec 1, 2015
Merged

Engines support on Minions! #29245

merged 3 commits into from
Dec 1, 2015

Conversation

s0undt3ch
Copy link
Collaborator

No description provided.

@s0undt3ch s0undt3ch added Feature new functionality including changes to functionality and code refactors, etc. Expert Review Needed labels Nov 27, 2015
@garethgreenaway
Copy link
Contributor

👍

@cachedout
Copy link
Contributor

Go Go Jenkins!

@cachedout
Copy link
Contributor

This looks good but I'd like to see the tests pass first.

@s0undt3ch
Copy link
Collaborator Author

Of course :)

@cachedout
Copy link
Contributor

@s0undt3ch I think these signal changes need to be extended to the syndic as well. Firing up the test suite shows the following:

Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/home/mp/devel/salt/tests/integration/__init__.py", line 249, in start
    getattr(daemon, start_fun)()
  File "/home/mp/devel/salt/salt/minion.py", line 1955, in tune_in
    signal.signal(signal.SIGTERM, self.clean_die)
AttributeError: 'Syndic' object has no attribute 'clean_die'

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Nov 30, 2015
cachedout pushed a commit that referenced this pull request Dec 1, 2015
Merge pull request #29245 from s0undt3ch/features/minion-engines
f6d23d8 
Engines support on Minions!
@cachedout cachedout merged commit f6d23d8 into saltstack:develop Dec 1, 2015
@pass-by-value
Copy link
Contributor

🌠

@aboe76 aboe76 mentioned this pull request Sep 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature new functionality including changes to functionality and code refactors, etc. Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s0undt3ch @garethgreenaway @cachedout @pass-by-value