Allow 'salt' command metadata to be a dict #26606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking 'salt' on the command line, using the '--metadata' option will not allow you to pass in data that will be represented in Python as a dict. This data will be represented as a string. There are situations where using a dict for metadata is desirable. For instance, if one would want to pass a number of named options as metadata. To accomplish this, the metadata is simply fed through the function: 'salt.utils.args.yamlify_arg'. This function is versatile: if the original input is not a string, it will return the original input. If it fails to parse the input into the dict or other such object, it will return the original input. Signed-off-by: Sergey Kizunov <sergey.kizunov@ni.com>
jfindlay
added
Core
|
This looks perfect. Great fix! |
basepi
added a commit
that referenced
this pull request
Aug 25, 2015
Allow 'salt' command metadata to be a dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking 'salt' on the command line, using the '--metadata'
option will not allow you to pass in data that will be represented
in Python as a dict. This data will be represented as a string.
There are situations where using a dict for metadata is desirable.
For instance, if one would want to pass a number of named options as
metadata.
To accomplish this, the metadata is simply fed through the function:
'salt.utils.args.yamlify_arg'. This function is versatile: if the
original input is not a string, it will return the original input. If
it fails to parse the input into the dict or other such object, it
will return the original input.
Signed-off-by: Sergey Kizunov sergey.kizunov@ni.com