Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting the state chunk by __id__ on MultiStateResult #141

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

s0undt3ch
Copy link
Contributor

Fixes #140

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #141 (cdb791c) into master (55add98) will decrease coverage by 0.79%.
The diff coverage is 20.00%.

❗ Current head cdb791c differs from pull request most recent head 9b6f011. Consider uploading reports for the commit 9b6f011 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   85.39%   84.61%   -0.78%     
==========================================
  Files          96       96              
  Lines        5605     5364     -241     
  Branches      621      619       -2     
==========================================
- Hits         4786     4538     -248     
- Misses        625      630       +5     
- Partials      194      196       +2     
Flag Coverage Δ
Linux 84.51% <20.00%> (-0.77%) ⬇️
Py35 68.20% <20.00%> (-0.02%) ⬇️
Py36 84.48% <20.00%> (-0.01%) ⬇️
Py37 ?
Py38 ?
Py39 ?
PyTest61 68.22% <20.00%> (-1.49%) ⬇️
PyTest62 84.36% <20.00%> (-0.69%) ⬇️
PyTest70 84.44% <20.00%> (-0.68%) ⬇️
PyTest71 ?
Salt3005rc2 84.51% <20.00%> (-0.77%) ⬇️
src 77.53% <20.00%> (-0.78%) ⬇️
tests 95.20% <ø> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/saltfactories/utils/functional.py 73.37% <20.00%> (-2.70%) ⬇️
...ntegration/factories/daemons/syndic/test_syndic.py 21.06% <0.00%> (-9.98%) ⬇️
tests/integration/conftest.py 66.67% <0.00%> (-4.76%) ⬇️
src/saltfactories/client.py 31.92% <0.00%> (-4.08%) ⬇️
...ctional/factories/base/test_salt_daemon_factory.py 96.56% <0.00%> (-3.44%) ⬇️
src/saltfactories/plugins/factories.py 82.76% <0.00%> (-1.61%) ⬇️
src/saltfactories/utils/virtualenv.py 73.96% <0.00%> (-1.53%) ⬇️
src/saltfactories/bases.py 75.76% <0.00%> (-1.52%) ⬇️
...ntegration/factories/daemons/container/conftest.py 81.82% <0.00%> (-1.51%) ⬇️
... and 58 more

Fixes saltstack#140

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the master branch 2 times, most recently from dce3bc6 to b3b8c84 Compare November 4, 2022 10:34
… to handle it

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch merged commit 83144c3 into saltstack:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow getting the state chunk by __id__ on MultiStateResult
1 participant